Add analysis_types passthrough from Flotilla to SARA - #1133
Merged
Conversation
Carry per-inspection analysis selections from Flotilla through ISAR to SARA without inspecting their semantics. The REST field 'analysisTypes' on each inspection definition is parsed into InspectionTask.analysis_types, copied onto InspectionMetadata, and re-emitted as 'required_analysis' on the MQTT inspection result payload that SARA consumes. The same list is also written to the metadata sidecar JSON uploaded alongside the blob. Backward compatible in both directions: missions without the field produce null on the wire, and SARA falls back to its existing default-analysis-by-file-extension behaviour.
aeshub
force-pushed
the
add-analysis-types-passthrough
branch
from
May 17, 2026 13:55
f9c24a0 to
3330449
Compare
This was referenced May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Carry a per-inspection
analysis_typeslist from Flotilla through ISAR to SARA, without ISAR inspecting the values. ISAR is a courier here; SARA validates.StartMissionInspectionDefinition.analysis_types: list[str] | Noneis threaded onto everyInspectionTask, copied toInspectionMetadata, and re-emitted asrequired_analysison the MQTTInspectionResultPayloadconsumed by SARA. The list is also written to the metadata sidecar JSON.nullon the wire; SARA falls back to its existing default-analysis-by-file-extension behaviour.inspection_target,inspection_description).Related PRs
Tests
Drive-by